[MCH] add functionality and protections in mapping - #12913

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass
async-2023-pp-apass1
async-2022-pp-apass6
async-2022-pp-apass4
async-mc
async-data

Hi @pillot,
I looked at the PR and it is good for me to approve once you have fixed the whitespace issue in Segmentation.h
One question thought, do you really want to keep both:
std::vector getCatPadIndices(int dualSampaId) const;
and std::vector catPadIndices(int dualSampaId) const;
as as far as I understood, they return the same information but one is just faster than the other?
Cheers,
Laure

Hi @lmassacr ,
catPadIndices(...) is the old function that I renamed and made private. It is used to fill the internal map of indices.
getCatPadIndices(...) is public and I changed it to return the indices stored in this map.
So there is only one visible function to get the indices, the fastest one, but both are needed.
Cheers,
Philippe